My metagross can't seem to help me out in a battle. Ill give its info so somebody can help me out.

Metagross @ Life Orb
Phsyical Wall/Confusion Inducer

Meteor Mash
Swagger
Block
Iron Defense
Strategy: I use swagger because metagross has high def should it backfire on me, to confuse after using block, to keep the opponent from switching out and healing the confusion. (Don't ask me how it has block my friend traded it to me that way, but i don't think he hacks or uses cheats.) I set up iron defense if i should need a strong phsyical wall to protect me from my opponents possible high atk stat pokemon, then while they're confused and hitting themselves, i meteor mash them to death.

Why can't the above pokemon and strategy work for me? Seriously, i need advice!

Should i replace iron defense with trick room, or the life orb with a quick claw?

Block is learned by HGSS move tutor.

Swagger is a very risky but bad strategy to use as if they KO you or remove the confusion you just set them up to sweep your team.

If you want to stick with swagger than use

Swagger
Rock polish
Iron head
Earthquake

RP makes you faster so you can swagger before an attack, Iron head has the flinch chance which drags confusion out longer. EQ for coverage or you can use Thunder punch for the para rate to further annoy with confusion/flinch.

item assistance? how about quick claw?

ps: i think trick room would be good.

just remember...

this little guy- r.o.c.k.s!

Quick claw is banned , and also , Metagross does not have THAT good defenses. A +2 Neutral hitting attack would do quite a bit.

Meta gross doesn't get trick room.

What kind of metagross do you want? i suggest lead metagross or CB

a phsyical wall/confusion inducer

Confusion is unreliable and not a staple in battle. There are much better physical walls out there, such as Skarmory, forretress ad Suicune. All have there own unique abilities and traits however Skarmory is probably the best as it has access to recovery that isn't rest which is very un-reliable. Skarmory also keeps the steel typing and flying which means your team has an immunity to poison and ground which can be very importent.
Skarmory can also set up entry Hazzards in Spikes and Stealth rock which is fantastic. Skarmory's mediocre special defense means it should be paired up with a big special wall like blissey or snorlax.

Here is a link to skarmory sets. http://www.smogon.com/dp/pokemon/skarmory

and heres blissey http://www.smogon.com/dp/pokemon/blissey

I use a metagross as a mixed attacker / sweeper with meteor mash and psyic and hammer arm. I use agility and then sweep it's that easy.